Third attempt at fixing Kotlin 2.2 compat #4613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2025
This was referenced Aug 7, 2025
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Third attempt at fixing Kotlin 2.2 compat ([#4613](https://github.com/getsentry/sentry-java/pull/4613))If none of the above apply, you can opt out of this check by adding |
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
adinauer
merged commit 1d5a803
into
08-06-second_attempt_to_fix_kotlin_2.2
18 of 37 checks passed
|
Merging this so we don't have to review changes in other PRs that were replaced in this PR |
adinauer
added a commit
that referenced
this pull request
Aug 7, 2025
* Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat (#4613) --------- Co-authored-by: Sentry Github Bot <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -145,7 +145,7 @@ fun toRequestUrl(uri: URI): StringBuffer? { | |||
| url.append(':').append(port) | |||
| } | |||
|
|
|||
| if (uri?.isNotBlank()) { | |||
| if (uri.isNotBlank()) { | |||
There was a problem hiding this comment.
Bug: Null URI Handling Error
A NullPointerException can occur because the null-safe call uri?.isNotBlank() was changed to uri.isNotBlank(). The uri variable is assigned from URI.rawPath, which can return null when the URI has no path component, removing the necessary null check.
adinauer
added a commit
that referenced
this pull request
Aug 11, 2025
* Fix Spring 7 and Spring Boot 4 modules * Attempt to fix kotlin 2.2 issue * Second attempt to fix Kotlin 2.2 (#4610) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat (#4613) --------- Co-authored-by: Sentry Github Bot <[email protected]> * Address compose-related issues * Fix tests for Spring 7 and Spring Boot 4 (#4614) * Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat * Fix tests for Spring 7 and Spring Boot 4 * Move Spring 7 and Spring Boot 4 packages (#4615) * Move Spring 7 and Spring Boot 4 packages * Fix class not found due to OTel not supporting spring boot 4 yet (#4616) * Format code * some fixes * change kotlin 1.8 to 1.9 and some cleanup * ignore warnings about api level that is not relevant * fix optional dependencies in SentryAutoConfiguration * Update trace origin * Remove duplicate e2e test config * Update Strings for Spring 7 and Spring Boot 4 * Disable Spring Boot 4 agentless e2e tests for now --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: markushi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps